Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fakes instead of mocks for use case tests #86

Merged
merged 42 commits into from
May 15, 2024
Merged

Use fakes instead of mocks for use case tests #86

merged 42 commits into from
May 15, 2024

Conversation

hielfx
Copy link
Member

@hielfx hielfx commented May 9, 2024

Closes #85

@hielfx hielfx added the kind/refactoring Restructuring process with no user functionality changes label May 9, 2024
hielfx added 20 commits May 9, 2024 14:56
@hielfx
refactor: add some fake providers to use in test cases
92eb6a4
@hielfx
test: use new fake git provider in github tests
9e4cd17
@hielfx
test: use new fake repository provider in github tests
41a9606
@hielfx
test: use new fake pull request provider in github tests
f30c462
@hielfx
test: add new case for thje fake pull request provider
54d3404
@hielfx
test: add new fake repository provider in jira tests
7a73496
@hielfx
test: add new fake git and pull request providers in jira tests
d692696
@hielfx
refactor: remove old mock provider initializers
d30bb62
@hielfx
test: remove unnecessary remote branches set on tests
e5267aa
@hielfx
test: remove unnecessary test initialization
8dff3dd
@hielfx
test: refactor 99-sample-issue in test cases and use specific branch …
f810e61 
…configuration
@hielfx
refactor: add fake issue tracker
a103d3a
@hielfx
chore: remove fakes from sonar scanner
db97a52
@hielfx
teat: add fake github issue tracker on test cases
bdb8f6d
@hielfx
test: add fake jira issue tracker on test cases
90b3f2b
@hielfx
test: remove unnecessary initialization method
021d9c4
@hielfx
test: add fake issue tracker provider in test cases
07f4e23
@hielfx
test: remove unnecessary initialization method
b493417
@hielfx
test: mock GetBranchName method in test with actual expected branch
fd9c2c4
@hielfx
test: remove unnecessary default branch property
b95513a
@hielfx hielfx marked this pull request as ready for review May 13, 2024 11:43
@hielfx hielfx requested a review from a team as a code owner May 13, 2024 11:43
@hielfx hielfx marked this pull request as draft May 13, 2024 12:28
hielfx added 16 commits May 14, 2024 11:39
@hielfx
test: fake git provider initialization outside package
cfb73b3
@hielfx
test: fake pull request provider initialization outside package
887fa4f
@hielfx
test: fake issue tracker initialization outside package
6660788
@hielfx
test: mock GetBranchName method in create branch test cases
26a7457
@hielfx
test: fake issue tracker provider initialization outside package
30cda96
@hielfx
test: unexport helper initializer functions
e6dfed7
@hielfx
test: fake issue tracker and issue tracker provider for create branch…
f98fd77 
… test cases
@hielfx
test: fake repository provider for crete branch test cases
fcd0cc0
@hielfx
test: fake git provider usage for github in create branch test cases
9c6ad60
@hielfx
test: remove commented loc in test cases
f4e0d2a
@hielfx
test: refactor test with git initialization
c0e4a4d
@hielfx
test: refactor test with pull request initialization
d917ec3
@hielfx
test: refactor test with issue tracker initialization
d677500
@hielfx
test: refactor test with repository provider initialization
2ed1314
@hielfx
test: refactor test with git provider initalization in branch test cases
342ffb4
@hielfx
test: remove s.Assert().XXXX and use s.XXXX directly as it's the same
50a93eb
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hielfx hielfx marked this pull request as ready for review May 15, 2024 08:36
@hielfx hielfx merged commit dade496 into main May 15, 2024
4 checks passed
@hielfx hielfx deleted the refactoring/GH-85-use-fakes-instead-of-moc branch May 15, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismaelgonval ismaelgonval ismaelgonval approved these changes

Assignees
No one assigned
Labels
kind/refactoring Restructuring process with no user functionality changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use fakes instead of mocks for use case tests
2 participants
@hielfx @ismaelgonval